Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Ionic 5 Refresher with icon overlays content #20377

Closed
0x426 opened this issue Feb 4, 2020 · 3 comments
Closed

bug: Ionic 5 Refresher with icon overlays content #20377

0x426 opened this issue Feb 4, 2020 · 3 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@0x426
Copy link

0x426 commented Feb 4, 2020

Bug Report

Ionic version:

[x] 5.x

Current behavior:
<ion-refresher> overlays the content after upgrading from Ionic 4 to Ionic 5(RC).

Expected behavior:
<ion-refresher> does not overlay the content and works like in Ionic 4.

Steps to reproduce:
See fiddle here: https://jsfiddle.net/mwjbh0fa/1/
Video: https://streamable.com/ggge3

Related code:

I guess the behavior results in the changes of this change.

As far as I could debug it, the <main> element in the shadow-root is on the same z-index as the <ion-refresher> itself. In Ionic 4 the refresher was behind the content or in other words, the content overlayed the <ion-refresher>.

Ionic info:

Ionic:

   Ionic CLI                     : 6.0.1 (/Users/[my-user]/.nvm/versions/node/v13.7.0/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.0.0-rc.2
   @angular-devkit/build-angular : 0.803.24
   @angular-devkit/schematics    : 8.3.24
   @angular/cli                  : 8.3.24
   @ionic/angular-toolkit        : 2.1.2

Cordova:

   Cordova CLI       : not installed
   Cordova Platforms : not available
   Cordova Plugins   : not available

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   Android SDK Tools : 26.1.1 (/Users/[my-user]/Library/Android/sdk/)
   ios-sim           : 8.0.2
   NodeJS            : v13.7.0 (/Users/[my-user]/.nvm/versions/node/v13.7.0/bin/node)
   npm               : 6.13.7
   OS                : macOS Catalina
   Xcode             : Xcode 11.3.1 Build version 11C504```
@ionitron-bot ionitron-bot bot added the triage label Feb 4, 2020
@liamdebeasi
Copy link
Contributor

Thanks for the issue. Can you give the following dev build a try and let me know if it resolves your issue? 5.0.0-dev.202002042013.bc7d822

@0x426
Copy link
Author

0x426 commented Feb 5, 2020

Thanks for your fast response here too!

Works like a charm, great job 👏

@ionitron-bot
Copy link

ionitron-bot bot commented Mar 6, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants