-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): translucent toolbar blur no longer obscures entering page title #20314
Conversation
@@ -9,13 +9,15 @@ | |||
} | |||
|
|||
@supports (backdrop-filter: blur(0)) { | |||
.header-translucent-ios { | |||
.header-background { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this apply to MD too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in the header.ios.scss file, so it should be fine, right? Or do I still need .header-translucent-ios .header-background
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that scoped used to do that, but I'm seeing it work fine. I wonder why we specify the class + mode in all of the CSS files though instead of just using .header-translucent
or ion-header
then.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #19158
What is the new behavior?
'.header-background
where the backdrop filter will be applied to.Does this introduce a breaking change?
Other information