Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content): resolve height inheritance issues #20309

Merged
merged 3 commits into from
Jan 27, 2020
Merged

fix(content): resolve height inheritance issues #20309

merged 3 commits into from
Jan 27, 2020

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 27, 2020 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20305

What is the new behavior?

  • Move #scroll-content to be a parent of .inner-scroll
  • Moved the background property from .inner-scroll to #scroll-content
  • Updated iOS PTR to translate .inner-scroll instead of #scroll-content

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jan 27, 2020
@liamdebeasi liamdebeasi marked this pull request as ready for review January 27, 2020 16:03
@liamdebeasi liamdebeasi merged commit 09bef71 into master Jan 27, 2020
@liamdebeasi liamdebeasi deleted the content branch January 27, 2020 18:00
@liamdebeasi liamdebeasi mentioned this pull request Jan 27, 2020
Closed
@lincolnthree
Copy link

This seems to keep things working here with fixed/floating items. Interesting changes. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamdebeasi @lincolnthree