Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fab-button): add close button icon property #19626

Merged

Conversation

anagstef
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When a ion-fab is used with a list inside it. If you activate it, then a close icon appears inside the ion-fab-button that cannot be changed.

What is the new behavior?

This PR exposes a new property to be able to change the icon shown when fab is activated. Defaults to the previous one: close.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added package: angular @ionic/angular package package: core @ionic/core package labels Oct 11, 2019
@brandyscarney brandyscarney added this to the 5.2.0 milestone Jun 8, 2020
@brandyscarney brandyscarney requested a review from liamdebeasi June 8, 2020 19:51
@brandyscarney brandyscarney merged commit 698e526 into ionic-team:master Jun 8, 2020
@brandyscarney
Copy link
Member

Thank you for the PR, this is great!

@anagstef anagstef deleted the expose-fab-close-button-icon branch June 9, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants