Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item): allow setting flex alignment on parent item #19278

Merged
merged 5 commits into from
May 29, 2020

Conversation

brandyscarney
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

fixes #18703

What is the new behavior?

  • Inherits alignment in inner item, allowing users to change the alignment on item itself

Does this introduce a breaking change?

  • Yes
  • No

Other information

inherits alignment in inner item

fixes #18703
@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Sep 5, 2019
@brandyscarney
Copy link
Member Author

Causes issues with Screenshot, needs more investigation

Screen Shot 2019-09-05 at 2 12 46 PM

@brandyscarney brandyscarney merged commit 882f8fe into master May 29, 2020
@brandyscarney brandyscarney deleted the fix-item-alignment branch May 29, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the ION-ITEM css
1 participant