feat(nav-link): merge nav-push/pop/set-root into a single component #18909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,21 @@ | |||
| # ion-nav-push | |||
There was a problem hiding this comment.
Suggested change
| # ion-nav-push | |
| # ion-nav-link |
| @@ -0,0 +1,21 @@ | |||
| # ion-nav-push | |||
|
|
|||
| `NavPush` is a component used to navigate to the specified component. | |||
There was a problem hiding this comment.
Suggested change
| `NavPush` is a component used to navigate to the specified component. | |
| A navigation link is used to navigate to a specified component. The component can be navigated to by going `forward`, `back` or as a `root` component. |
| # ion-nav-push | ||
|
|
||
| `NavPush` is a component used to navigate to the specified component. | ||
| It is the element form of `NavController.push()` |
There was a problem hiding this comment.
Suggested change
| It is the element form of `NavController.push()` | |
| It is the element form of calling the `push()`, `pop()`, and `setRoot()` methods on the navigation controller. |
| @Element() el!: HTMLElement; | ||
|
|
||
| /** | ||
| * Component to navigate to. Only used if the `routerDirection` is `forward` or `root`. |
There was a problem hiding this comment.
Suggested change
| * Component to navigate to. Only used if the `routerDirection` is `forward` or `root`. | |
| * Component to navigate to. Only used if the `routerDirection` is `"forward"` or `"root"`. |
| @Prop() component?: NavComponent; | ||
|
|
||
| /** | ||
| * Data you want to pass to the component as props. Only used if the `routerDirection` is `forward` or `root`. |
There was a problem hiding this comment.
Suggested change
| * Data you want to pass to the component as props. Only used if the `routerDirection` is `forward` or `root`. | |
| * Data you want to pass to the component as props. Only used if the `routerDirection` is `"forward"` or `"root"`. |
| @Prop() componentProps?: ComponentProps; | ||
|
|
||
| /** | ||
| * It specifies the transition direction when navigating to another page. |
There was a problem hiding this comment.
Suggested change
| * It specifies the transition direction when navigating to another page. | |
| * The transition direction when navigating to another page. |
| @@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core'; | |||
| import { OverlayController, ToastOptions } from '../../interface'; | |||
| import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays'; | |||
|
|
|||
| /** | |||
| * @deprecated Use the `toastController` exported from core | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated Use the `toastController` exported from core | |
| * @deprecated Use the `toastController` exported from core. |
| @@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core'; | |||
| import { ComponentRef, OverlayController, PopoverOptions } from '../../interface'; | |||
| import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays'; | |||
|
|
|||
| /** | |||
| * @deprecated Use the `popoverController` exported from core | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated Use the `popoverController` exported from core | |
| * @deprecated Use the `popoverController` exported from core. |
| @@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core'; | |||
| import { OverlayController, PickerOptions } from '../../interface'; | |||
| import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays'; | |||
|
|
|||
| /** | |||
| * @deprecated Use the `pickerController` exported from core | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated Use the `pickerController` exported from core | |
| * @deprecated Use the `pickerController` exported from core. |
| @@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core'; | |||
| import { ComponentRef, ModalOptions, OverlayController } from '../../interface'; | |||
| import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays'; | |||
|
|
|||
| /** | |||
| * @deprecated Use the `modalController` exported from core | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated Use the `modalController` exported from core | |
| * @deprecated Use the `modalController` exported from core. |
| @@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core'; | |||
| import { LoadingOptions, OverlayController } from '../../interface'; | |||
| import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays'; | |||
|
|
|||
| /** | |||
| * @deprecated Use the `loadingController` exported from core | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated Use the `loadingController` exported from core | |
| * @deprecated Use the `loadingController` exported from core. |
| @@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core'; | |||
| import { AlertOptions, OverlayController } from '../../interface'; | |||
| import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays'; | |||
|
|
|||
| /** | |||
| * @deprecated Use the `alertController` exported from core | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated Use the `alertController` exported from core | |
| * @deprecated Use the `alertController` exported from core. |
| @@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core'; | |||
| import { ActionSheetOptions, OverlayController } from '../../interface'; | |||
| import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays'; | |||
|
|
|||
| /** | |||
| * @deprecated Use the `actionSheetController` exported from core | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated Use the `actionSheetController` exported from core | |
| * @deprecated Use the `actionSheetController` exported from core. |
brandyscarney
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: closes #18933
What is the new behavior?
Does this introduce a breaking change?
Other information