fix(input): change height to max height on input #17394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR gives the same behavior in Chrome, Safari and FF, when the input is not wrapped in html tags : see example with different browsers https://glitch.com/edit/#!/regular-magician?path=index.html:5:8
brandyscarney
changed the title
brandyscarney
approved these changes
Feb 12, 2019
liamdebeasi
approved these changes
Mar 19, 2019
|
Thanks! 🎉 |
kiku-jw
pushed a commit
to kiku-jw/ionic
that referenced
this pull request
May 16, 2019
…onic-team#17394) This PR gives the same behavior in Chrome, Safari and FF, when the input is not wrapped in html tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This PR tries to add the same behavior in Chrome, Safari and FF, when the input is not wrapped in html tags : see example with different browsers
https://glitch.com/edit/#!/regular-magician?path=index.html:5:8
Changes proposed in this pull request: