fix(overlay): register backbutton handler only when needed #15615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ionic-team#15601. When listening to ionBackButton events, only registers the backbutton handler if there is actually an overlay. This will give a chance to handlers with lower priority to eventually run.
|
@manucorporat Would you mind to review this PR before next release ? |
|
Thanks a lot for the PR! |
|
Thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
When listening to
ionBackButtonevents, only registers thebackbuttonhandler if there is actually an overlay. This will give a chance to handlers with lower priority to eventually run.Changes proposed in this pull request:
ionBackButtonlistener for overlays, only register the handler if there is actually an overlayIonic Version: 4.0.0-beta.11
Fixes: #15601