Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ionic 4] ion-button inherits --width var from ion-menu #15522

Closed
AVatch opened this issue Sep 9, 2018 · 2 comments
Closed

[ionic 4] ion-button inherits --width var from ion-menu #15522

AVatch opened this issue Sep 9, 2018 · 2 comments
Assignees

Comments

@AVatch
Copy link

AVatch commented Sep 9, 2018

Bug Report

Ionic Info

ionic 4.0.0-beta.8

Describe the Bug
ion-button inherits the width var set in the ion-menu component, breaking any usage of the button inside the menu. Specifically in toolbars/header components, because the button now has the same width as the sidemenu.

Expected Behavior
Resolve the name conflict either by renaming the menu's --width to --menu-width or ensure that variable does not propagate down

@ionitron-bot ionitron-bot bot added triage and removed triage labels Sep 9, 2018
@netsesame2
Copy link

netsesame2 commented Sep 14, 2018

I confirm this issue.
@ionic/angular 4.0.0-beta.8 introduce many new css variables. After updated, many unexpected UI changes.

Can be fixed by:

ion-button {
    --width: none;
}

@brandyscarney brandyscarney self-assigned this Sep 19, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Oct 19, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants