fix(refresher): resolve undefined issues when updating component (#20322

) fixes #20320
ionic-team · Jan 28, 2020 · 59d8687 · 59d8687
1 parent f1e3e42
commit 59d8687
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/core/src/components/refresher/refresher.tsx b/core/src/components/refresher/refresher.tsx
@@ -124,10 +124,11 @@ export class Refresher implements ComponentInterface {
   @Event() ionStart!: EventEmitter<void>;
 
   private checkNativeRefresher() {
-    if (shouldUseNativeRefresher(this.el, getIonMode(this))) {
+    const useNativeRefresher = shouldUseNativeRefresher(this.el, getIonMode(this));
+    if (useNativeRefresher && !this.nativeRefresher) {
       const contentEl = this.el.closest('ion-content');
       this.setupNativeRefresher(contentEl);
-    } else {
+    } else if (!useNativeRefresher) {
       this.destroyNativeRefresher();
     }
   }
@@ -360,7 +361,7 @@ export class Refresher implements ComponentInterface {
   }
 
   private async setupNativeRefresher(contentEl: HTMLIonContentElement | null) {
-    if (this.scrollListenerCallback || !contentEl || this.nativeRefresher) {
+    if (this.scrollListenerCallback || !contentEl || this.nativeRefresher || !this.scrollEl) {
       return;
     }