fix(config): using sessionStorage is not safe

ionic-team · Aug 22, 2018 · 091b433 · 091b433
1 parent 88613ff
commit 091b433
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/core/src/utils/config.ts b/core/src/utils/config.ts
@@ -19,12 +19,20 @@ const IONIC_PREFIX = 'ionic:';
 const IONIC_SESSION_KEY = 'ionic-persist-config';
 
 export function configFromSession(): any {
-  const configStr = window.sessionStorage.getItem(IONIC_SESSION_KEY);
-  return configStr ? JSON.parse(configStr) : {};
+  try {
+    const configStr = window.sessionStorage.getItem(IONIC_SESSION_KEY);
+    return configStr ? JSON.parse(configStr) : {};
+  } catch {
+    return {};
+  }
 }
 
 export function saveConfig(config: any) {
-  window.sessionStorage.setItem(IONIC_SESSION_KEY, JSON.stringify(config));
+  try {
+    window.sessionStorage.setItem(IONIC_SESSION_KEY, JSON.stringify(config));
+  } catch {
+    return;
+  }
 }
 
 export function configFromURL() {