Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build your first app Angular uses deprecated cameraPhoto object #1609

Closed
ne6toto opened this issue Nov 15, 2021 · 1 comment
Closed

Build your first app Angular uses deprecated cameraPhoto object #1609

ne6toto opened this issue Nov 15, 2021 · 1 comment

Comments

@ne6toto
Copy link

ne6toto commented Nov 15, 2021

Hi, I am new here, but I believe I found the following issue while working through the "Build your first app" excercise with Angular:

The "Saving Photos to the Filesystem" instructs the user to use the CameraPhoto object in
private async savePicture(cameraPhoto: CameraPhoto) { }
Looking through @capacitor's Camera definitions.d.ts file it seems that CameraPhoto is deprecated, and that Photo should be used instead. This would however result in a name conflict with the previous step, where the user declares an interface with the same name:
export interface Photo { filepath: string; webviewPath: string; }

I would be happy to submit a pull request for this, but I was unable to find the code responsible for that webpage in this repository.

@jcesarmobile
Copy link
Member

Thanks for the issue, it was fixed long ago.
The proper repository for issues on the docs is https://github.com/ionic-team/ionic-docs/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants