Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(textarea): add support for the shape property with soft, round and rectangular options #29788

Merged
merged 44 commits into from
Aug 22, 2024
Merged

feat(textarea): add support for the shape property with soft, round and rectangular options #29788

merged 44 commits into from
Aug 22, 2024

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Aug 21, 2024 •
edited
Loading

Issue number: internal

What is the current behavior?

The Ionic theme Textarea only supports the default round shape.

What is the new behavior?

  • Adds support for "soft", "round" and "rectangular" shapes in the Ionic theme, with "round" as the default
  • Adds a shape folder and test with examples
  • Adds an e2e test with screenshots for all shapes

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

brandyscarney and others added 30 commits August 16, 2024 13:02
@brandyscarney
feat(textarea): add default textarea styles
66f7231
@brandyscarney
fix(textarea): add proper structure, padding and spacing
98bdc88
@brandyscarney
style: lint
e55e4e2
@brandyscarney
feat(textarea): add size property with default set to medium
66f4adb
@brandyscarney
test(textarea): add test for sizes
25ae1a1
@brandyscarney
fix(textarea): move padding and spacing to all fills
ab46a02
@brandyscarney
chore(): add updated snapshots
91a5823
@brandyscarney
chore: build
ee00a2d
@brandyscarney
Merge branch 'next' into ROU-10916
2f7e2a7
@brandyscarney
docs(textarea): improve size description
1db5bbc
@brandyscarney
fix(textarea): separate common and native styles
e54fb4d
@Ionitron
chore(): add updated snapshots
74d9fb9
@brandyscarney
refactor(textarea): more cleanup between common and native
f4b7bc3
@brandyscarney
style: remove escapes
4947747
@brandyscarney
style: lint
9a46466
@brandyscarney
fix(textarea): use min height to autogrow
694242b
@brandyscarney
feat(textarea): add sm and lg sizes for ionic theme
2273735
@brandyscarney
test(textarea): update size test to include sm and lg
f852a85
@brandyscarney
chore(): add updated snapshots
630c12f
@brandyscarney
style: lint
f82126a
@brandyscarney
test(textarea): update basic test
cff97fa
@brandyscarney
fix(textarea): allow height to collapse to use the true min height
1b3fc07
@brandyscarney
Merge branch 'ROU-10916' into ROU-10917
6df45be
@brandyscarney
chore(): add updated snapshots
9fe763a
@brandyscarney
style(textarea): remove unused files, fix imports
ea98cf3
@brandyscarney
test(textarea): remove round shape
9e3ff8b
@brandyscarney
fix(textarea): use space var for textarea margin
559a6f3
@brandyscarney
fix(textarea): use tokens and properly position slotted content
e6d53fb
@brandyscarney
style: lint
56b58ee
@brandyscarney
chore(): add updated snapshots
f5d0725
@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 9:35pm

@github-actions github-actions bot added the package: core @ionic/core package label Aug 21, 2024
Base automatically changed from ROU-10917 to next August 21, 2024 20:15
@brandyscarney brandyscarney marked this pull request as ready for review August 21, 2024 21:07
@brandyscarney brandyscarney requested a review from a team as a code owner August 21, 2024 21:07
thetaPC
thetaPC approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit ca4c0a5 into next Aug 22, 2024
46 checks passed
@brandyscarney brandyscarney deleted the ROU-10918 branch August 22, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenOsodrac BenOsodrac BenOsodrac approved these changes

@thetaPC thetaPC thetaPC approved these changes

@OS-giulianasilva OS-giulianasilva Awaiting requested review from OS-giulianasilva OS-giulianasilva is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandyscarney @thetaPC @BenOsodrac @Ionitron