From 9fe472fa73fe1cd5bdf6ebb36bb5cfe15fbbc8b3 Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Thu, 12 Oct 2023 13:58:19 -0400 Subject: [PATCH 1/2] fix(angular): export missing lifecycle interfaces for standalone package --- packages/angular/standalone/src/index.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/angular/standalone/src/index.ts b/packages/angular/standalone/src/index.ts index 209fa25d777..6b675977fe1 100644 --- a/packages/angular/standalone/src/index.ts +++ b/packages/angular/standalone/src/index.ts @@ -22,6 +22,10 @@ export { Platform, NavParams, IonicRouteStrategy, + ViewWillEnter, + ViewDidEnter, + ViewWillLeave, + ViewDidLeave, } from '@ionic/angular/common'; export { IonNav } from './navigation/nav'; export { From 489b3f5e37627ae00a92e4e12fb5b3be1d9784fe Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Thu, 12 Oct 2023 14:26:51 -0400 Subject: [PATCH 2/2] fix: exports --- packages/angular/common/src/index.ts | 1 + .../{ => common}/src/types/ionic-lifecycle-hooks.ts | 0 packages/angular/src/index.ts | 7 ++++--- 3 files changed, 5 insertions(+), 3 deletions(-) rename packages/angular/{ => common}/src/types/ionic-lifecycle-hooks.ts (100%) diff --git a/packages/angular/common/src/index.ts b/packages/angular/common/src/index.ts index 7b834ffe14a..bd432ea3bac 100644 --- a/packages/angular/common/src/index.ts +++ b/packages/angular/common/src/index.ts @@ -18,6 +18,7 @@ export { Platform } from './providers/platform'; export { bindLifecycleEvents, AngularDelegate } from './providers/angular-delegate'; export type { IonicWindow } from './types/interfaces'; +export type { ViewWillEnter, ViewWillLeave, ViewDidEnter, ViewDidLeave } from './types/ionic-lifecycle-hooks'; export { NavParams } from './directives/navigation/nav-params'; diff --git a/packages/angular/src/types/ionic-lifecycle-hooks.ts b/packages/angular/common/src/types/ionic-lifecycle-hooks.ts similarity index 100% rename from packages/angular/src/types/ionic-lifecycle-hooks.ts rename to packages/angular/common/src/types/ionic-lifecycle-hooks.ts diff --git a/packages/angular/src/index.ts b/packages/angular/src/index.ts index 3ebea61c445..a64ef4341fd 100644 --- a/packages/angular/src/index.ts +++ b/packages/angular/src/index.ts @@ -37,11 +37,12 @@ export { AngularDelegate, NavParams, IonicRouteStrategy, + ViewWillEnter, + ViewWillLeave, + ViewDidEnter, + ViewDidLeave, } from '@ionic/angular/common'; -// TYPES -export * from './types/ionic-lifecycle-hooks'; - // PACKAGE MODULE export { IonicModule } from './ionic-module';