Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slides): resolve prototype pollution in swiper v5 #23344

Merged
merged 2 commits into from
May 21, 2021
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented May 21, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23342

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label May 21, 2021
@liamdebeasi liamdebeasi merged commit a708c41 into master May 21, 2021
@liamdebeasi liamdebeasi deleted the swiper-fix branch May 21, 2021 18:17
@3zzy
Copy link

3zzy commented May 29, 2021

but Framework v6 is bringing changes that makes this a non-issue

@liamdebeasi Ionic Framework v6 will get rid of SwiperJS you mean?

@liamdebeasi
Copy link
Contributor Author

We are not getting rid of SwiperJS in Framework v6, but we are going to be recommending that developers use the framework integrations provided by the Swiper team instead. We will have more information as we get closer to the v6 launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Prototype pollution vulnerability in bundled swiper library
2 participants