From ed21209f6d35e6b4a51323d4af4bd7f5feaaa90e Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 18 May 2020 16:26:16 -0400 Subject: [PATCH 1/7] textarea max --- core/src/components/textarea/textarea.scss | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/core/src/components/textarea/textarea.scss b/core/src/components/textarea/textarea.scss index c2e7f879b43..21d88f214ad 100644 --- a/core/src/components/textarea/textarea.scss +++ b/core/src/components/textarea/textarea.scss @@ -39,7 +39,9 @@ flex: 1; width: 100%; - box-sizing: border-box; + + max-width: 100%; + max-height: 100%; background: var(--background); color: var(--color); @@ -49,6 +51,7 @@ white-space: pre-wrap; z-index: $z-index-item-input; + box-sizing: border-box; } :host(.ion-color) { @@ -74,6 +77,12 @@ // Native Textarea // -------------------------------------------------- +.textarea-wrapper { + max-width: inherit; + max-height: inherit; +} + + .native-textarea { @include border-radius(var(--border-radius)); @include margin(0); @@ -83,8 +92,8 @@ display: block; width: 100%; - max-width: 100%; - max-height: 100%; + max-width: inherit; + max-height: inherit; border: 0; From e7cd7bb7d2577d3f747036e15f5959537a29cfcf Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 18 May 2020 16:30:33 -0400 Subject: [PATCH 2/7] Revert --- core/src/components/textarea/textarea.scss | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/core/src/components/textarea/textarea.scss b/core/src/components/textarea/textarea.scss index 21d88f214ad..408129ab118 100644 --- a/core/src/components/textarea/textarea.scss +++ b/core/src/components/textarea/textarea.scss @@ -82,7 +82,6 @@ max-height: inherit; } - .native-textarea { @include border-radius(var(--border-radius)); @include margin(0); @@ -92,8 +91,8 @@ display: block; width: 100%; - max-width: inherit; - max-height: inherit; + max-width: 100%; + max-height: 100%; border: 0; From 67712fb2279a9efc7e1974f01a04d0b39af04234 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 18 May 2020 16:32:41 -0400 Subject: [PATCH 3/7] remove unneeded code --- core/src/components/textarea/textarea.scss | 3 --- 1 file changed, 3 deletions(-) diff --git a/core/src/components/textarea/textarea.scss b/core/src/components/textarea/textarea.scss index 408129ab118..8bfa8f4c21a 100644 --- a/core/src/components/textarea/textarea.scss +++ b/core/src/components/textarea/textarea.scss @@ -40,9 +40,6 @@ width: 100%; - max-width: 100%; - max-height: 100%; - background: var(--background); color: var(--color); From 276672d520abbb890e400e3430e4daf7072d68ae Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Mon, 18 May 2020 16:39:14 -0400 Subject: [PATCH 4/7] inherit min dimensions too --- core/src/components/textarea/textarea.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/core/src/components/textarea/textarea.scss b/core/src/components/textarea/textarea.scss index 8bfa8f4c21a..c3605548c70 100644 --- a/core/src/components/textarea/textarea.scss +++ b/core/src/components/textarea/textarea.scss @@ -77,6 +77,9 @@ .textarea-wrapper { max-width: inherit; max-height: inherit; + + min-width: inherit; + min-height: inherit; } .native-textarea { From 802745adb5c4879f79383610423ef6761f75369e Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 19 May 2020 09:56:05 -0400 Subject: [PATCH 5/7] lint --- core/src/components/textarea/textarea.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/components/textarea/textarea.scss b/core/src/components/textarea/textarea.scss index c3605548c70..e9caa134eb4 100644 --- a/core/src/components/textarea/textarea.scss +++ b/core/src/components/textarea/textarea.scss @@ -75,11 +75,11 @@ // -------------------------------------------------- .textarea-wrapper { - max-width: inherit; - max-height: inherit; min-width: inherit; + max-width: inherit; min-height: inherit; + max-height: inherit; } .native-textarea { From 4388fb98b981244279a7515a24f0c71fa85a288e Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 19 May 2020 12:09:06 -0400 Subject: [PATCH 6/7] Update core/src/components/textarea/textarea.scss Co-authored-by: Brandy Carney --- core/src/components/textarea/textarea.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/core/src/components/textarea/textarea.scss b/core/src/components/textarea/textarea.scss index e9caa134eb4..079764c6818 100644 --- a/core/src/components/textarea/textarea.scss +++ b/core/src/components/textarea/textarea.scss @@ -75,7 +75,6 @@ // -------------------------------------------------- .textarea-wrapper { - min-width: inherit; max-width: inherit; min-height: inherit; From 88f68707c1fc822cbc0342cac706b7c7dba517ec Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 19 May 2020 12:09:12 -0400 Subject: [PATCH 7/7] Update core/src/components/textarea/textarea.scss Co-authored-by: Brandy Carney --- core/src/components/textarea/textarea.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/components/textarea/textarea.scss b/core/src/components/textarea/textarea.scss index 079764c6818..b31380e242f 100644 --- a/core/src/components/textarea/textarea.scss +++ b/core/src/components/textarea/textarea.scss @@ -48,6 +48,7 @@ white-space: pre-wrap; z-index: $z-index-item-input; + box-sizing: border-box; }