From 033b776d846bf17c2e8b0fb1e59e411eed728417 Mon Sep 17 00:00:00 2001
From: Sina <sinajavaheri@gmail.com>
Date: Tue, 25 Apr 2017 12:53:34 +0430
Subject: [PATCH 1/4] fix(select): RTL fix for select

RTL fix for select
---
 src/components/select/select.ios.scss |  9 +++++++++
 src/components/select/select.md.scss  |  9 +++++++++
 src/components/select/select.scss     |  4 ++++
 src/components/select/select.wp.scss  | 11 +++++++++++
 4 files changed, 33 insertions(+)

diff --git a/src/components/select/select.ios.scss b/src/components/select/select.ios.scss
index a28b960f006..f5e88f29c12 100644
--- a/src/components/select/select.ios.scss
+++ b/src/components/select/select.ios.scss
@@ -26,6 +26,10 @@ $select-ios-placeholder-color:   $select-ios-icon-color !default;
   padding: $select-ios-padding-top $select-ios-padding-right  $select-ios-padding-bottom $select-ios-padding-left;
 }
 
+[dir="rtl|] .select-ios {
+  padding: $select-ios-padding-top $select-ios-padding-left  $select-ios-padding-bottom $select-ios-padding-right;
+}
+
 .select-ios .select-placeholder {
   color: $select-ios-placeholder-color;
 }
@@ -54,3 +58,8 @@ $select-ios-placeholder-color:   $select-ios-icon-color !default;
 
   pointer-events: none;
 }
+
+[dir="rtl"] .select-ios .select-icon .select-icon-inner {
+  right: 5px;
+  left: auto;
+}
\ No newline at end of file
diff --git a/src/components/select/select.md.scss b/src/components/select/select.md.scss
index 1a69693f3f3..70fabb1c2dc 100644
--- a/src/components/select/select.md.scss
+++ b/src/components/select/select.md.scss
@@ -26,6 +26,10 @@ $select-md-placeholder-color:   $select-md-icon-color !default;
   padding: $select-md-padding-top $select-md-padding-right $select-md-padding-bottom $select-md-padding-left;
 }
 
+[dir="rtl"] .select-md {
+  padding: $select-md-padding-top $select-md-padding-left $select-md-padding-bottom $select-md-padding-right;
+}
+
 .select-md .select-placeholder {
   color: $select-md-placeholder-color;
 }
@@ -58,3 +62,8 @@ $select-md-placeholder-color:   $select-md-icon-color !default;
 
   pointer-events: none;
 }
+
+[dir="rtl"] .select-md .select-icon .select-icon-inner {
+  right: 5px;
+  left: auto;
+}
diff --git a/src/components/select/select.scss b/src/components/select/select.scss
index 74f13c087f8..84d435c1f72 100644
--- a/src/components/select/select.scss
+++ b/src/components/select/select.scss
@@ -49,3 +49,7 @@ ion-select {
 .select-popover ion-list {
   margin: $select-popover-list-margin-top $select-popover-list-margin-right $select-popover-list-margin-bottom $select-popover-list-margin-left;
 }
+
+[dir="rtl"] .select-popover ion-list {
+  margin: $select-popover-list-margin-top $select-popover-list-margin-left $select-popover-list-margin-bottom $select-popover-list-margin-right;
+}
diff --git a/src/components/select/select.wp.scss b/src/components/select/select.wp.scss
index 521e10ed053..1da2e73e57e 100644
--- a/src/components/select/select.wp.scss
+++ b/src/components/select/select.wp.scss
@@ -52,6 +52,10 @@ $select-wp-placeholder-color:   $select-wp-icon-color !default;
   line-height: 3rem;
 }
 
+[dir="rtl"] .select-wp {
+  margin: $select-wp-margin-top $select-wp-margin-left $select-wp-margin-bottom $select-wp-margin-right;
+}
+
 .select-wp .select-placeholder {
   color: $select-wp-placeholder-color;
 }
@@ -86,6 +90,13 @@ $select-wp-placeholder-color:   $select-wp-icon-color !default;
   pointer-events: none;
 }
 
+[dir="rtl"] .select-wp .select-icon .select-icon-inner {
+  right: 5px;
+  left: auto;
+  border-left: $select-wp-icon-arrow-width solid $select-wp-icon-color;
+  border-right: none;
+}
+
 .select-wp .select-text {
   min-height: 3rem;
 }

From 02a758f79649019672a2b0b4149a5b9d0f7a70ef Mon Sep 17 00:00:00 2001
From: Sina <sinajavaheri@gmail.com>
Date: Wed, 26 Apr 2017 00:56:27 +0430
Subject: [PATCH 2/4] missing newline at end of the file

---
 src/components/select/select.ios.scss | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/select/select.ios.scss b/src/components/select/select.ios.scss
index f5e88f29c12..c3b18fa7d29 100644
--- a/src/components/select/select.ios.scss
+++ b/src/components/select/select.ios.scss
@@ -62,4 +62,4 @@ $select-ios-placeholder-color:   $select-ios-icon-color !default;
 [dir="rtl"] .select-ios .select-icon .select-icon-inner {
   right: 5px;
   left: auto;
-}
\ No newline at end of file
+}

From a33c182b53bdb25ae9e61d40f6ac8feb662760b7 Mon Sep 17 00:00:00 2001
From: Sina <sinajavaheri@gmail.com>
Date: Tue, 2 May 2017 13:39:20 +0430
Subject: [PATCH 3/4] mistyped | instead of "

---
 src/components/select/select.ios.scss | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/select/select.ios.scss b/src/components/select/select.ios.scss
index c3b18fa7d29..0ad1e6afa6f 100644
--- a/src/components/select/select.ios.scss
+++ b/src/components/select/select.ios.scss
@@ -26,7 +26,7 @@ $select-ios-placeholder-color:   $select-ios-icon-color !default;
   padding: $select-ios-padding-top $select-ios-padding-right  $select-ios-padding-bottom $select-ios-padding-left;
 }
 
-[dir="rtl|] .select-ios {
+[dir="rtl"] .select-ios {
   padding: $select-ios-padding-top $select-ios-padding-left  $select-ios-padding-bottom $select-ios-padding-right;
 }
 

From 3aa1662dd7094359045dffd4a34b2e937d6a4210 Mon Sep 17 00:00:00 2001
From: Sina <sinajavaheri@gmail.com>
Date: Sat, 13 May 2017 22:00:43 +0430
Subject: [PATCH 4/4] Remove left right padding margin

Remove left right padding margin in favor of #11342
---
 src/components/select/select.ios.scss | 9 ---------
 src/components/select/select.md.scss  | 9 ---------
 src/components/select/select.scss     | 4 ----
 src/components/select/select.wp.scss  | 6 ------
 4 files changed, 28 deletions(-)

diff --git a/src/components/select/select.ios.scss b/src/components/select/select.ios.scss
index 1861beafd68..893b71b36e8 100644
--- a/src/components/select/select.ios.scss
+++ b/src/components/select/select.ios.scss
@@ -30,10 +30,6 @@ $select-ios-placeholder-color:   $select-ios-icon-color !default;
   @include padding($select-ios-padding-top, $select-ios-padding-end, $select-ios-padding-bottom, $select-ios-padding-start);
 }
 
-[dir="rtl"] .select-ios {
-  padding: $select-ios-padding-top $select-ios-padding-left  $select-ios-padding-bottom $select-ios-padding-right;
-}
-
 .select-ios .select-placeholder {
   color: $select-ios-placeholder-color;
 }
@@ -62,8 +58,3 @@ $select-ios-placeholder-color:   $select-ios-icon-color !default;
 
   pointer-events: none;
 }
-
-[dir="rtl"] .select-ios .select-icon .select-icon-inner {
-  right: 5px;
-  left: auto;
-}
diff --git a/src/components/select/select.md.scss b/src/components/select/select.md.scss
index 4dbbcb2168a..39e176a123c 100644
--- a/src/components/select/select.md.scss
+++ b/src/components/select/select.md.scss
@@ -30,10 +30,6 @@ $select-md-placeholder-color:   $select-md-icon-color !default;
   @include padding($select-md-padding-top, $select-md-padding-end, $select-md-padding-bottom, $select-md-padding-start);
 }
 
-[dir="rtl"] .select-md {
-  padding: $select-md-padding-top $select-md-padding-left $select-md-padding-bottom $select-md-padding-right;
-}
-
 .select-md .select-placeholder {
   color: $select-md-placeholder-color;
 }
@@ -66,8 +62,3 @@ $select-md-placeholder-color:   $select-md-icon-color !default;
 
   pointer-events: none;
 }
-
-[dir="rtl"] .select-md .select-icon .select-icon-inner {
-  right: 5px;
-  left: auto;
-}
diff --git a/src/components/select/select.scss b/src/components/select/select.scss
index c2f718ffe6c..29eca2c2267 100644
--- a/src/components/select/select.scss
+++ b/src/components/select/select.scss
@@ -53,7 +53,3 @@ ion-select {
 .select-popover ion-list {
   @include margin($select-popover-list-margin-top, $select-popover-list-margin-end, $select-popover-list-margin-bottom, $select-popover-list-margin-start);
 }
-
-[dir="rtl"] .select-popover ion-list {
-  margin: $select-popover-list-margin-top $select-popover-list-margin-left $select-popover-list-margin-bottom $select-popover-list-margin-right;
-}
diff --git a/src/components/select/select.wp.scss b/src/components/select/select.wp.scss
index e4468841d71..5ac8077b743 100644
--- a/src/components/select/select.wp.scss
+++ b/src/components/select/select.wp.scss
@@ -56,10 +56,6 @@ $select-wp-placeholder-color:   $select-wp-icon-color !default;
   line-height: 3rem;
 }
 
-[dir="rtl"] .select-wp {
-  margin: $select-wp-margin-top $select-wp-margin-left $select-wp-margin-bottom $select-wp-margin-right;
-}
-
 .select-wp .select-placeholder {
   color: $select-wp-placeholder-color;
 }
@@ -96,8 +92,6 @@ $select-wp-placeholder-color:   $select-wp-icon-color !default;
 }
 
 [dir="rtl"] .select-wp .select-icon .select-icon-inner {
-  right: 5px;
-  left: auto;
   border-left: $select-wp-icon-arrow-width solid $select-wp-icon-color;
   border-right: none;
 }