-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Modal Dismiss on setRoot #8734
Comments
OT: Is there already a Plunker template for RC0 or RC1? |
Modals are not longer part of the main stack. You have to pop the modal manually, or activate the dismissOnPageChange setting. |
Thank you for the explanation. |
@manucorporat Actually, there seems to be no "dismissOnPageChange" for Modals, only for Toasts and Loading. At least not within ModalOptions |
@n00b42 you are right. I think dismissOnPageChange is not available in modal, because pushing a page inside modal would dismiss it. I would suggest you to manually close the modal when you |
@manucorporat Actually, setRoot is called from somewhere else, so its a bit tricky for the modal to "know" when it should close.... but I will think about a workaround |
Short description of the problem:
(Page1 is successfully poped and Page2 popped in the "background")
What behavior are you expecting?
As it is stated that a modal is pushed to the nav stack and setRoot is said to destroy elements on the nav stack.
Therefore, I would expect the modal to be dismissed too.
Ionic info
Cordova CLI: 6.3.1
Ionic Framework Version: 2.0.0-rc.1
Ionic CLI Version: 2.1.0
Ionic App Lib Version: 2.1.0-beta.1
OS: Windows 10
Node Version: v6.7.0
Probably related
#8437
The text was updated successfully, but these errors were encountered: