Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item divider "color" attribute doesn't work with RC0 #8628

Closed
smichelotti opened this issue Oct 11, 2016 · 2 comments
Closed

Item divider "color" attribute doesn't work with RC0 #8628

smichelotti opened this issue Oct 11, 2016 · 2 comments
Assignees

Comments

@smichelotti
Copy link

smichelotti commented Oct 11, 2016

Before RC0, we could set the "secondary" attribute on an <ion-item-divider> and it would change the color like this:

<ion-list>
    <ion-item-group *ngFor="let division of teams">
        <ion-item-divider secondary>{{division.divisionName}}</ion-item-divider>
        <button ion-item *ngFor="let team of division.divisionTeams" (click)="itemTapped($event, team)">
            {{team.name}}
        </button>
    </ion-item-group>
</ion-list>

Per the RC0 documentation, we now use a color attribute:

<ion-list>
    <ion-item-group *ngFor="let division of teams">
        <ion-item-divider color="secondary">{{division.divisionName}}</ion-item-divider>
        <button ion-item *ngFor="let team of division.divisionTeams" (click)="itemTapped($event, team)">
            {{team.name}}
        </button>
    </ion-item-group>
</ion-list>

This no longer changes the color of the item divider correctly. Upon inspection in Chrome, the class attribute is getting: "item item-md item-md-secondary", but the .item-md-secondary CSS is getting overridden. See screen shot.

item-divider-color

Additionally, here is a Plunker that shows the problem: http://plnkr.co/edit/w6Xqqv?p=preview

@ekhmoi
Copy link

ekhmoi commented Oct 11, 2016

possible duplicate of #8376

@jgw96
Copy link
Contributor

jgw96 commented Oct 11, 2016

Hello all! Thanks for opening an issue with us! I am going to close this issue as a duplicate of #8376 .

@jgw96 jgw96 closed this as completed Oct 11, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants