Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover Arrow flipped when shown above item (iOS) #8419

Closed
ColinFrick opened this issue Oct 3, 2016 · 5 comments
Closed

Popover Arrow flipped when shown above item (iOS) #8419

ColinFrick opened this issue Oct 3, 2016 · 5 comments
Assignees

Comments

@ColinFrick
Copy link
Contributor

Short description of the problem:

When a popover opens above an element (f.e. button in footer) the arrow still points up.

What behavior are you expecting?

Popover arrow pointing to the element (down)

Steps to reproduce:

  1. Create a page with a footer
  2. Add button to footer
  3. Open Popover with this button

Other information:
Caused by:

CSS class popover-bottom is added to the popover itself, but in the iOS styling it's handled as a child element:
https://github.com/driftyco/ionic/blob/master/src/components/popover/popover.ios.scss#L69
https://github.com/driftyco/ionic/blob/master/src/components/popover/popover.ios.scss#L74

Remove space should fix the issue

.popover-ios.popover-bottom .popover-arrow {
  top: auto;
  bottom: -10px;
}

.popover-ios.popover-bottom .popover-arrow::after {
  top: -6px;
}

Which Ionic Version? 1.x or 2.x
2.0.0-rc.0

Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.3.1
Gulp version: CLI version 3.9.1
Gulp local:
Ionic Framework Version: 2.0.0-rc.0
Ionic CLI Version: 2.1.0
Ionic App Lib Version: 2.1.0-beta.1
OS: Distributor ID: LinuxMint Description: Linux Mint 17.3 Rosa
Node Version: v6.7.0

@zakton5
Copy link
Contributor

zakton5 commented Oct 7, 2016

Any way this could get moved in to the rc.1 milestone?

@manucorporat
Copy link
Contributor

@zakton5 can you provide a screenshot?

@ColinFrick
Copy link
Contributor Author

@manucorporat
25fa0d13-3f4b-4055-be51-e5c1c9ca16ae

@manucorporat
Copy link
Contributor

@brandyscarney confirmed this is a real issue:
screen shot 2016-10-10 at 12 17 40

@brandyscarney brandyscarney modified the milestone: 1.3.2 Oct 12, 2016
@brandyscarney
Copy link
Member

Thanks for the PR! This will be fixed in the rc.1 release. 😄

@brandyscarney brandyscarney added this to the 2.0.0-rc.1 milestone Oct 12, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants