Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Scroll update after scrolling stops #8267

Closed
danbucholtz opened this issue Sep 28, 2016 · 17 comments
Closed

Virtual Scroll update after scrolling stops #8267

danbucholtz opened this issue Sep 28, 2016 · 17 comments
Assignees
Milestone

Comments

@danbucholtz
Copy link
Contributor

Make virtual scroll update the position and displayed elements when scrolling is done.

@danbucholtz danbucholtz added the v2 label Sep 28, 2016
@danbucholtz danbucholtz self-assigned this Sep 28, 2016
@danbucholtz danbucholtz added this to the 2.0.0-rc.1 milestone Sep 28, 2016
@danbucholtz
Copy link
Contributor Author

I am 90% done with this already, so assigning to RC.1

@ghost
Copy link

ghost commented Oct 4, 2016

Can you please solve virtual scrolling going to top after change in dataset in this update????virtual scrolling is a tremendous feature especially when used with infinite scroll but this scrolling problem is just rendering it useless in many cases like in News Feed.

@danbucholtz
Copy link
Contributor Author

@azzamasghar,

Please file a separate issue for that problem. It won't be fixed with the change discussed in this issue.

Thanks,
Dan

@danbucholtz
Copy link
Contributor Author

Sorry, accidentally assigned you @manucorporat.

@brandyscarney brandyscarney modified the milestones: 2.0.0-rc.1, 2.0.0-rc.2 Oct 13, 2016
@brandyscarney brandyscarney removed this from the 2.0.0-rc.1 milestone Oct 17, 2016
@brandyscarney brandyscarney modified the milestone: 2.0.0-rc.3 Nov 4, 2016
@brandyscarney brandyscarney modified the milestones: 2.0.0-rc.3, 2.0.0-rc.4 Nov 17, 2016
@jumptidus
Copy link

jumptidus commented Nov 18, 2016

rc.1 rc.2 rc.3
nothing!
I really need this..............Please

@DavidTalamona
Copy link

DavidTalamona commented Nov 18, 2016

I just read an informative article about that problem: http://developer.telerik.com/featured/scroll-event-change-ios-8-big-deal/ - especially the part at "One caveat for Cordova developers".

Seems like it's a problem with the "old" webview used by Cordova and cannot be fixed until the "new" webview is acceptable as a replacement.
So @danbucholtz, is there anything the IONIC team could do about it? Don't think you're implementing custom scrolling, are you?
Think we all have to wait for Cordova to implement the WKWebView.

If I'm getting this right, then please add some note at the virtualScroll docs because that issue basically makes it useless for iOS.

Update:
Just found the this related IONIC blog post: http://blog.ionic.io/cordova-ios-performance-improvements-drop-in-speed-with-wkwebview/

@adamdbradley
Copy link
Contributor

@DavidTalamona Yes, we've built a plugin to use WKWebView: http://blog.ionic.io/cordova-ios-performance-improvements-drop-in-speed-with-wkwebview/

And Virtual Scroll adjusts for UIWebView since it doesn't fire scroll events during inertia. I'm working on this issue now, thanks.

@adamdbradley
Copy link
Contributor

@jumptidus Can you explain more what the issue is and what you need fixed?

@jumptidus
Copy link

we use ionic for forums. need build a long list for posts.we choose virtualscroll but when I use ion-infinite update it .virtualscroll always scroll to top..

our user love scroll scroll scroll....so have a really long list cannot use ngfor.

understand what i mean

my English is poor.sorry

@faraazc
Copy link

faraazc commented Nov 23, 2016

@mlynch @adamdbradley @jgw96 virtual scroll+infinite scroll is a basic requirement for any data driven apps. Please get this fixed as early as possible. Possibly before final release. on addition of new data in to the dataset scroll should not move to top. I tried many tweaks but could not achieve. Please help us on this. Thanks in advance

@jumptidus
Copy link

Hi...
Will fix in rc4?
@adamdbradley

@jgw96
Copy link
Contributor

jgw96 commented Dec 28, 2016

Hello all! So just to clear up some confusion here this issue is about the virtual scroll updating when scrolling has stopped to make sure that the page is not left with blank space that should have elements rendered in it. The issue that you guys are asking about here with the virtual scroll scrolling back to the top when updating it with data as you are scrolling is tracked here #6423.

@jgw96
Copy link
Contributor

jgw96 commented Dec 28, 2016

I am currently testing this issue (virtual scroll leaving white space and not rendering when you stop scrolling). On UiWebView, which was originally where the biggest issue was, I can confirm that it is fixed. Will post more of my findings as I test.

@jgw96
Copy link
Contributor

jgw96 commented Dec 28, 2016

So from my testing with an iphone 5, Nexus 6, and chrome on the desktop i can confirm that this issue is not happening on the latest release (rc4). 🎉

@jgw96
Copy link
Contributor

jgw96 commented Dec 28, 2016

Hello everyone! I am going to close this now as I cannot reproduce this issue in RC4, but if you still run into this issue please feel free to comment and I will happily reopen. Thanks for using Ionic!

@jgw96 jgw96 closed this as completed Dec 28, 2016
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 5, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants