Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: No Sidemenu on modal page #7586

Closed
mpaland opened this issue Aug 7, 2016 · 2 comments
Closed

bug: No Sidemenu on modal page #7586

mpaland opened this issue Aug 7, 2016 · 2 comments

Comments

@mpaland
Copy link

mpaland commented Aug 7, 2016

Type: bug

Ionic Version: 2.x

Platform: all

Up to beta10 there was the possibility to present a modal page like this:

let modal = new ViewController(ModalPage, this.params);
this.nav.present(modal);

modal.onDismiss((data: any) => {
  if (data) {
    console.log(data);
  }
});

Why modal? Because of retrieving mandatory data from the modal page.
Problem: The ModalPage used the sidemenu of the app - up to beta10. In beta11 the sidemenu does not open anymore.
Meaning it opens but behind the modal page - which is an overlay now.

In beta 11 the nav.present() method is gone and got replaced by the (Modal)Controller.present().

For navigation is is required to use a sidemenu on a modal page. It is necessary to navigate from a modal page to a subpage via the sidemenu and navigate back to the modalpage which is dismissed then.
Therefore I consider taking away the nav.present() method as a bad idea - knowing why and for what intention you did that.

@jgw96
Copy link
Contributor

jgw96 commented Aug 9, 2016

Hello! Thanks for opening an issue with us. So one of the main reasons we changed to our new overlay components api is that it matches native closer. In a native app with a sidemenu and modals (twitter for android, inbox by google are perfect examples) the sidemenu is not accessible from a modal. Because of this i would recommend either that you consider changing from using a modal to a page so that your user will still have access to the sidemenu or rethink the need for the user to have to use the sidemenu while in the modal. Sorry if this causes any hassle for you, but these changes were necessary to keep Ionic 2 more in line with native and what mobile users expect. Thanks for using Ionic!

@jgw96 jgw96 closed this as completed Aug 9, 2016
@mpaland
Copy link
Author

mpaland commented Aug 10, 2016

@jgw96 thanx for clarification.
But this should really be pointed out in the beta11 release notes / changelog!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants