Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbar background not getting override #7500

Closed
guillenotfound opened this issue Aug 1, 2016 · 3 comments
Closed

Tabbar background not getting override #7500

guillenotfound opened this issue Aug 1, 2016 · 3 comments

Comments

@guillenotfound
Copy link
Contributor

Short description of the problem:

I'm trying to override $tabbar-md-background and $tabbar-ios-background, but anything happens, instead I get the $toolbar-background value.

If I want to modify the ion-tabbar background I have to do:

ion-tabbar {
  background: #f8f8f8; 
}

It works, but with scss variables should be cleaner.

Which Ionic Version? 1.x or 2.x
2.x

Run ionic info from terminal/cmd prompt: (paste output below)

Cordova CLI: 6.3.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.10-201607291454
Ionic CLI Version: 2.0.0-beta.32
Ionic App Lib Version: 2.0.0-beta.18
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v4.3.0
Xcode version: Xcode 8.0 Build version 8S128d
@guillenotfound
Copy link
Contributor Author

How can I test this kind of things with ionic running gulp watch.e2e ? I don't know where should I modify scss variables.

@jgw96 jgw96 added css and removed platform:ios labels Aug 1, 2016
@brandyscarney
Copy link
Member

It looks like you are using the nightly version of the framework. I made some changes to the Sass variables for tabs and I believe those changes are in that nightly. Can you take a look at this diff to see the changes: af01841

tabbar-ios-background -> tabs-ios-background

We'll have this in the changelog as well. :) If you're running the ionic repo locally and trying to modify the sass variables for the e2e tests you can add them in the themes directory: https://github.com/driftyco/ionic/tree/master/src/themes. We plan on improving the documentation behind which Sass variables apply to which component as part of this issue: ionic-team/ionic-site#613

@guillenotfound
Copy link
Contributor Author

Ooops missed that commit! Thanks :D

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants