Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic 2 Popover: Toolbar within ion-header or ion-footer doesn't stay fixed #7098

Closed
szerner opened this issue Jun 28, 2016 · 9 comments
Closed
Assignees
Labels
ionitron: v3 moves the issue to the ionic-v3 repository

Comments

@szerner
Copy link

szerner commented Jun 28, 2016

In a scrollable Popover (content size is larger than the window of the popover), a <ion-toolbar> within <ion-header> or <ion-footer> scrolls together with the content.

The toolbar should stay fixed on its relative position (top resp. bottom).

Popover template (with title and button to close):

<ion-header>
    <ion-toolbar>
        <ion-title>{{name}}</ion-title>
        <ion-buttons right>
            <button (click)="closeInfo()">
                <ion-icon name="close"></ion-icon>
            </button>
        </ion-buttons>
    </ion-toolbar>
</ion-header>
<ion-content>
    <p [innerHtml]="description"></p>
</ion-content>

Tested with Ionic 2 beta.10 on Android and Chrome browser.

Your system information:

Cordova CLI: 6.2.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.10
Ionic CLI Version: 2.0.0-beta.32
Ionic App Lib Version: 2.0.0-beta.18
OS:
Node Version: v5.11.1
@szerner szerner changed the title Popover: Toolbar within ion-header or ion-footer doesn't stay fixed Ionic 2 Popover: Toolbar within ion-header or ion-footer doesn't stay fixed Jun 28, 2016
@jgw96 jgw96 added v2 and removed footer labels Jun 28, 2016
@jgw96
Copy link
Contributor

jgw96 commented Jun 28, 2016

Thanks for opening an issue with us! We are already aware of this issue and will be looking into it. Note to self - probably related to this issue: #7084

@brandyscarney brandyscarney self-assigned this Jul 1, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.11 milestone Jul 1, 2016
@jgw96 jgw96 removed this from the 2.0.0-beta.12 milestone Aug 9, 2016
@BradyNadeau
Copy link

Is there any update on this? Seems to still be an issue in RC1

@jbagaresgaray
Copy link

Any update for this bug??

@szerner
Copy link
Author

szerner commented Mar 7, 2017

Meanwhile I tried to switch from Popups to Modals, but then I lose the ability to style them individually...

@paragw09ckp
Copy link

Looks like it has not been fixed yet. Any idea if is in the plans?

@siphiwe
Copy link

siphiwe commented Sep 20, 2017

Bump.

@brandyscarney brandyscarney added this to the 4.x milestone Sep 20, 2017
@sarahtully
Copy link

For now I fixed this issue using ion-scroll: <ion-content><ion-scroll scrollY="true">...</ion-scroll></ion-content> and then using scss: ion-scroll { height: calc(100vh - 68px)} In our case .popover-content has a height: 100%; max-height: calc(100% - 12px). So to get the available scroll height it's 100vh - 68px (68px = 56px (ion-header height) + 12px (amount subtracted from the .popover-content height)); Hope this helps some of you resolve this issue while the Ionic team works on a resolution.

@adamdbradley adamdbradley added the ionitron: v3 moves the issue to the ionic-v3 repository label Nov 1, 2018
@imhoffd imhoffd added ionitron: v3 moves the issue to the ionic-v3 repository and removed ionitron: v3 moves the issue to the ionic-v3 repository labels Nov 1, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 1, 2018

Thanks for the issue! We have moved the source code and issues for Ionic 3 into a separate repository. I am moving this issue to the repository for Ionic 3. Please track this issue over there.

Thank you for using Ionic!

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 1, 2018

Issue moved to: ionic-team/ionic-v3#102

@ionitron-bot ionitron-bot bot closed this as completed Nov 1, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ionitron: v3 moves the issue to the ionic-v3 repository
Projects
None yet
Development

No branches or pull requests