Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic2 bug(tabs) - tab page without navbar results in navbar placeholder being transparent #6927

Closed
zakton5 opened this issue Jun 15, 2016 · 1 comment
Milestone

Comments

@zakton5
Copy link
Contributor

zakton5 commented Jun 15, 2016

Short description of the problem:

When a tab page does not contain an ion-navbar component, then the navbar placeholder in the ion-tabs component is left empty. This is fine, but because the CSS has min-height: 44px, content behind the current tab page can be seen.

What behavior are you expecting?

I would expect the navbar placeholder to be completely hidden, or its height to be 0 if the current tab page has no ion-navbar. The plunker below shows this bug on tab page 2.

Which Ionic Version? 2.x

Plunker that shows an example of your issue

https://plnkr.co/edit/XPoPzFsm03x8lvPrHMlH?p=preview

Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.2.0
Gulp version: CLI version 3.9.1
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.8
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
ios-deploy version: 1.8.4
ios-sim version: 5.0.6
OS: Mac OS X El Capitan
Node Version: v4.4.4
Xcode version: Xcode 7.3 Build version 7D175

@brandyscarney
Copy link
Member

This should be fixed by the beta 10 release. Please see the breaking changes & update steps and let us know if it's still an issue: https://github.com/driftyco/ionic/blob/master/CHANGELOG.md#200-beta10-2016-06-27

Also related:
#5556
#5164

Thanks for the issue!

@brandyscarney brandyscarney added this to the 2.0.0-beta.10 milestone Jun 30, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants