Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Toast backdrop dismiss should re-fire click #6519

Closed
ErkoKnoll opened this issue May 13, 2016 · 9 comments
Closed

feat: Toast backdrop dismiss should re-fire click #6519

ErkoKnoll opened this issue May 13, 2016 · 9 comments
Assignees
Milestone

Comments

@ErkoKnoll
Copy link

Type: feat

Ionic Version: 2.x

Platform: all

When Toast backdrop dismiss is enabled then first click is used to dispose the Toast but from UX point of view user expect that click would gregister wherever he clicked. If possible please re-fire that click with the same position so that use has to tap once to dispose the toast and also expect to get a response for that tap from the underlying UI.

@jgw96
Copy link
Contributor

jgw96 commented May 13, 2016

Hello! Thanks for opening an issue with us! Im sorry, but im having a hard time visualizing the issue you are having. Would you mind making a plunker that demonstrates the issue you are describing? Thanks!

@jgw96 jgw96 added the needs: reply the issue needs a response from the user label May 13, 2016
@WhatsThatItsPat
Copy link

I don't think a plunker is necessary here.

@ErkoKnoll is just saying that when you click the invisible backdrop to dismiss a Toast, it would be nice if the click "carried thru" and the intended action still happened. Users might be trying to tap a button and don't realize there is anything blocking them from doing so.

@jgw96
Copy link
Contributor

jgw96 commented May 13, 2016

Ahh thanks for clarifying @PatrickMcD ! Now i fully understand the issue. @ErkoKnoll Good suggestion!

@brandyscarney
Copy link
Member

Hey, so I think the solution to this is to make the backdrop darker by default so the user knows it's there, but also have a property to remove the backdrop. If the backdrop isn't there then any content they click while the toast is open will still fire, and if you wanted to dismiss the toast you could do so on the button click. Does that work?

@ErkoKnoll
Copy link
Author

I'd rather go with property to remove the backdrop, because most of the time toast disappears in few seconds. I just don't want to block the user interaction. I'm personally using it for notifications and by nature users shouldn't take any interaction to get rid of them.

@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label May 13, 2016
@brandyscarney brandyscarney self-assigned this May 13, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.8 milestone May 13, 2016
@brandyscarney
Copy link
Member

Ok, great. I'll work on adding this soon. Thanks for the issue!

@WhatsThatItsPat
Copy link

Maybe a listener could be added to ion-page or something when a toast is created, and any interaction caught there would do the job of the backdrop by removing the toast.

@alexbainbridge
Copy link

I am not so sure about refiring the click, however having a toast without a backdrop (so no need to prevent clicks), would be great. Also using them for notifications.

@brandyscarney
Copy link
Member

brandyscarney commented May 20, 2016

So the backdrop was removed entirely as part of issue #6291 and will be in the beta.8 release. If you'd like to check it out sooner, I've released a nightly version that can be installed by running the following in a terminal:

npm install --save [email protected]

If you haven't updated to beta.7 yet, check out the changelog for steps to update.

Thanks!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants