Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Collection-repeat resize beta.14-nightly #3054

Closed
gant02 opened this issue Feb 9, 2015 · 8 comments
Closed

bug: Collection-repeat resize beta.14-nightly #3054

gant02 opened this issue Feb 9, 2015 · 8 comments
Milestone

Comments

@gant02
Copy link

gant02 commented Feb 9, 2015

Type: bug

Platform: android 4.x webview

Hi,

It seems that the last update break the automatic resize when the device is rotate.

It works with beta 14 but not with the lastest nighly. My collection-repeat item is not recalculate when i rotate my screen (item size is the same than before the screen rotation).

No problem in the ionic codepen and on iOS, it seems to be only on android (tested on version 4.4)

@gant02 gant02 changed the title Bug: Collection-repeat resize beta.14-nightly-995 bug: Bug: Collection-repeat resize beta.14-nightly-995 Feb 9, 2015
@gant02 gant02 changed the title bug: Bug: Collection-repeat resize beta.14-nightly-995 bug: Collection-repeat resize beta.14-nightly-995 Feb 9, 2015
@ajoslin
Copy link
Contributor

ajoslin commented Feb 9, 2015

@adamdbradley this also happens with ng-repeat: http://codepen.io/anon/pen/pvdBzd

It appears to be a problem with clearing the cache right as a view loads. If we wait 100ms before clearing the cache, it works fine: http://codepen.io/anon/pen/LEOvPv

@ajoslin ajoslin assigned adamdbradley and unassigned ajoslin Feb 9, 2015
@adamdbradley adamdbradley added this to the 1.0.0-rc0 milestone Feb 9, 2015
@ajoslin ajoslin closed this as completed in b7a0968 Feb 9, 2015
@gant02
Copy link
Author

gant02 commented Feb 9, 2015

Sorry my problem is not solved. I don't use clearcache and with the last nighlty (1009), I still have the problem.
I made other tests and I seem to be linked to expose-aside-when="large" on my side menu. I removed it and the resiz

works.

On my tablet when i rotate the screen to landscape, the collection-repeat size seems to be equal to the size of the portrait width (picture portrait). And when i rotate to portrait, the width seems to be the size of the landscape.

No problem on iOS emulator.

portrait

landscape

@gant02
Copy link
Author

gant02 commented Feb 10, 2015

Can you reopen this issue?

Thanks.

@ajoslin ajoslin reopened this Feb 10, 2015
@gant02 gant02 changed the title bug: Collection-repeat resize beta.14-nightly-995 bug: Collection-repeat resize beta.14-nightly Feb 12, 2015
@adamdbradley adamdbradley assigned ajoslin and unassigned adamdbradley Feb 17, 2015
@gant02
Copy link
Author

gant02 commented Feb 20, 2015

Hello,
I created a codepen of my problem:

http://codepen.io/gnoumaster/full/ByrvOj/

If you comment the nightly version and uncomment the beta14 version js/css files, it works great the "+" sign is inside of the view. I think this is a css problem, I use ionic grid system (row/col) insead of the collection-repeat list. Maybe this is not the right things to do?

I also test with the collection-repeat codepen done by the ionic team, and i have the same problem is I define a flot:right to the image.

Thanks for your help !!

@ajoslin
Copy link
Contributor

ajoslin commented Feb 24, 2015

Can you try the latest nightly build?

@gant02
Copy link
Author

gant02 commented Feb 24, 2015

I tried with the latest nightly and i still have the same problem. You can reproduce it with my codepen and chrome or stock brower on android 4.4. You rotate the screen and the collection-repeat list is not resized.

@ajoslin
Copy link
Contributor

ajoslin commented Feb 25, 2015

There were two problems:

  1. exposing the side menu didn't cause collection-repeat to recalculate sizes
  2. collection repeat wasn't always correctly recalculating sizes.

Both are fixed now. Your codepen will work when the nightly build is up.

@gant02
Copy link
Author

gant02 commented Feb 25, 2015

Hi,

Perfect it works, thanks.

But now my list is really slow on my tablet (galaxy tab S) with expose-aside-when="large", without it's smooth as before.

I don't see this problem on the codepen :( Do you have any idea?

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants