fix(react): intellisense works with IntelliJ #29782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
thetaPC
commented
Aug 19, 2024
| @@ -62,17 +63,19 @@ | |||
| "@typescript-eslint/parser": "^5.48.2", | |||
| "eslint": "^7.32.0", | |||
| "fs-extra": "^9.0.1", | |||
| "jest": "^26.6.3", | |||
| "jest": "^29.7.0", | |||
| "jest-environment-jsdom": "^29.7.0", | |||
There was a problem hiding this comment.
jsdom is needed to be installed since Jest 26 no longer ships it by default since the test environment is now node by default. The test environment needs to be changed to jsdom when building a web app.
sean-perkins
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Great work on this 👏
I think this should be a fix or feat. Either: fix(react): intellisense works with IntelliJ or feat(react): generate functional components (as examples).
One thing to be aware with these changes is that it only fixes the problem in the generated component wrappers. All of the legacy components that use class components likely have the same issue. We need to make the migration at some point in the future to support React Router 6, so it might be worth migrating those manual components over one-by-one over future releases. It shouldn't be a breaking change since the APIs are remaining the same.
1 task
thetaPC
changed the title
brandyscarney
approved these changes
Aug 20, 2024
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Issue number: resolves ionic-team/stencil-ds-output-targets#476, resolves ionic-team/stencil-ds-output-targets#475, resolves #29848 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In v0.6.0 of the [React output target](https://www.npmjs.com/package/@stencil/react-output-target), the implementation was changed to leverage Lit's utility for creating React components from web components. This introduced some unforseen issues and breaking changes. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Reverts many of the changes from #29782 to downgrade the React output target package to the last stable version (v0.5.3) - Downgrades the version of Stencil to v4.20.0 (due to ionic-team/stencil#5983 causing problems with the downgraded output target) - Pins these versions and prevents Renovate from attempting to upgrade until the associated issues are resolved ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build for this version: `8.3.1-dev.11726167750.15400355` I tested the dev build against the use cases outlined in ionic-team/stencil-ds-output-targets#475 and ionic-team/stencil-ds-output-targets#476
brandyscarney
pushed a commit
that referenced
this pull request
Sep 17, 2024
Issue number: resolves ionic-team/stencil-ds-output-targets#476, resolves ionic-team/stencil-ds-output-targets#475, resolves #29848 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> <!-- Please describe the current behavior that you are modifying. --> In v0.6.0 of the [React output target](https://www.npmjs.com/package/@stencil/react-output-target), the implementation was changed to leverage Lit's utility for creating React components from web components. This introduced some unforseen issues and breaking changes. <!-- Please describe the behavior or changes that are being added by this PR. --> - Reverts many of the changes from #29782 to downgrade the React output target package to the last stable version (v0.5.3) - Downgrades the version of Stencil to v4.20.0 (due to ionic-team/stencil#5983 causing problems with the downgraded output target) - Pins these versions and prevents Renovate from attempting to upgrade until the associated issues are resolved - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build for this version: `8.3.1-dev.11726167750.15400355` I tested the dev build against the use cases outlined in ionic-team/stencil-ds-output-targets#475 and ionic-team/stencil-ds-output-targets#476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29755
What is the current behavior?
Types do not generate when a React app is opened in IntelliJ IDE.
What is the new behavior?
stencil/react-output-targetto the latestjest,ts-jest, andtypescriptbecause of the changes inpackages/react/tsconfig.jsonjest-environment-jsdombecause Jest 26 no longer ships it by default since the test environment is now node by default. The test environment needs to be changed tojsdomwhen building a web app.Does this introduce a breaking change?
No visual changes are introduced and there will be no changes needed by developers. Their apps will continue to work as is.
Other information
Dev build: 8.2.8-dev.11724100788.103018f2