refactor(range): remove legacy property and support for legacy syntax #29040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the tests for the legacy range syntax. A separate PR will be used to remove the implementation for the legacy syntax. --------- Co-authored-by: ionitron <[email protected]>
liamdebeasi
changed the title
This pull request includes the changes to remove the `legacy` property for the range as part of #29040. That pull request specifically focuses on updating tests to remove any legacy range usage. The internal ticket suggested separating these changes into individual pull requests. Please refer to the mentioned pull request for a detailed description of the combined changes from both pull requests. This will be merged into that pull request upon approval. --------- Co-authored-by: ionitron <[email protected]>
github-actions
bot
added
package: angular
liamdebeasi
requested review from
brandyscarney,
thetaPC,
sean-perkins and
a team
as code owners
brandyscarney
requested changes
Feb 14, 2024
core/src/components/range/range.tsx
Outdated
| @@ -861,8 +767,7 @@ Developers can dismiss this warning by removing their usage of the "legacy" prop | |||
| } | |||
|
|
|||
| render() { | |||
| const { legacyFormController } = this; | |||
| return legacyFormController.hasLegacyControl() ? this.renderLegacyRange() : this.renderRange(); | |||
| return this.renderRange(); | |||
There was a problem hiding this comment.
Can we just move the renderRange function into render instead?
There was a problem hiding this comment.
Fixed in a65ec85
|
I updated the legacy path in 5cdedc9. However, this test is skipped so there should be no noticeable difference on CI right now. |
brandyscarney
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
In Ionic Framework v7, we simplified the range syntax so that it was no longer required to be placed inside of an
ion-item. We maintained backwards compatibility by adding alegacyproperty which allowed it to continue to be styled properly when written in the following way:While this was supported in v7, console warnings were logged to notify developers that they needed to update this syntax for the best accessibility experience.
What is the new behavior?
Removes the
legacyproperty and support for the legacy syntax. Developers should follow the migration guide in the range documentation to update their apps. The new syntax requires alabeloraria-labelonion-range:Alternatively, the "label" slot can be used for developer who require custom HTML labels:
Removes the legacy tests under
range/test/legacy/and all related screenshotsRemoves the range usage in
item/test/disabled,item/test/legacy/disabledDoes this introduce a breaking change?
BREAKING CHANGE:
The
legacyproperty and support for the legacy syntax, which involved placing anion-rangeinside of anion-itemwith anion-label, have been removed from range. For more information on migrating from the legacy range syntax, refer to the Range documentation.