Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): remove border-right on ios stacked buttons #28821

Merged
merged 12 commits into from
Jan 17, 2024
Merged

fix(alert): remove border-right on ios stacked buttons #28821

merged 12 commits into from
Jan 17, 2024

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Jan 12, 2024

Issue number: internal


What is the current behavior?

When iOS alert has 3 or more buttons, those are rendered vertically. All but the last button will have a right border. There shouldn't be a right border when the buttons are stacked.

Group 2(1)

What is the new behavior?

  • Vertical buttons don't have a right border.
  • Separated the test in order to also test dark theme.

Screenshot 2024-01-12 at 1 00 54 PM
Screenshot 2024-01-12 at 12 58 22 PM

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@github-actions github-actions bot added the package: core @ionic/core package label Jan 12, 2024
@thetaPC thetaPC marked this pull request as ready for review January 12, 2024 21:15
@thetaPC thetaPC requested a review from a team as a code owner January 12, 2024 21:15
@thetaPC thetaPC requested review from sean-perkins and removed request for a team January 12, 2024 21:15
@thetaPC thetaPC changed the title fix(alert): use border-right on ios stacked buttons fix(alert): remove border-right on ios stacked buttons Jan 17, 2024
@thetaPC thetaPC added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit ad65824 Jan 17, 2024
46 checks passed
@thetaPC thetaPC deleted the FW-5632 branch January 17, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants