bug: Collection-Repeat with Caching and Modals causes app to crash in beta 14

[rajatrocks]

Type: bug

Platform: all

- Home tab has a collection-repeat list in it. Each element has a picture. - A second tab has a button to open a modal. - When the modal is shown, it calls ionic.trigger('resize'); _(line 2955 of ionic-angular.js)_ - The collection-repeat on the home tab (which is cached as of b14) listens to this, calls collectionRepeatManager.resize() which then renders **all the non-showing elements** in the list. If there are pictures, **all the pictures are loaded**. And when run on device, the app likely crashes with an out of memory error. - Turning off cache for the Home tab eliminates the problem. - Removing collection-repeat eliminates the problem. - Commenting out the call to ionic.trigger('resize') eliminates the problem (for me).

Codepen here: http://codepen.io/rajatrocks/pen/myOYLw

Discussion here: http://forum.ionicframework.com/t/collection-repeat-and-view-cache-weirdness/14651

[felquis]

Probably related to #2890

[miklernout]

+1

[ajoslin]

Fixed via bb866da

[ajoslin]

In short, the modal sends a resize event.

The old collection repeat would recalculate everything on the resize event.

The new collection repeat only recalculates on resize if the collection repeat is in view, and also doesn't recalculate everything anymore. It only recalculates what has to be recalculated on resize - up to the current scroll value.

[ajoslin]

Or in the case of your codepen, nothing needs to be recalculated anymore since it uses static item heights...

[ajoslin]

Latest nightly, you don't need item-height and item-width attributes anymore: http://codepen.io/anon/pen/wBjYJo

If you don't supply width/height, it will getComputedStyle() of the first element and use that for the width/height of every element.