fix(input): slotted buttons are clickable #28772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
commented
Jan 2, 2024
| @@ -259,15 +259,16 @@ | |||
|
|
|||
| // Input Has focus | |||
| // -------------------------------------------------- | |||
| // When the input has focus, then the input cover should be hidden | |||
There was a problem hiding this comment.
The associated code for this comment was removed in d817cc3#diff-25a4832c20c7342508f6e1921d7e0db8c6c7ef1b5053f643d665c8f45a84cd19R146.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28762
What is the current behavior?
Focused inputs have
pointer-events: none. This code was added in e27452b to address #5536. However, this causes slotted buttons to not be clickable when the input is focused because pointer events have been removed.This also causes the input to blur whenever you tap the label text.
This behavior only exists on
ion-input. Textarea is not affected.What is the new behavior?
This code was added several years ago for the (now) legacy syntax. I don't have full confidence that this won't break the legacy input because there's not a lot of context around why specifically this code was added. As a result, I scoped these styles only to the legacy input.
Does this introduce a breaking change?
Other information
Testing:
Dev build:
7.6.3-dev.11704229014.12cdc767