fix(nav, router-outlet): ios page transition does not cover menu on larger screens #28745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28737
What is the current behavior?
In #28246 we removed the overflow on Nav and Router Outlet to allow content to flow outside of these containers. This allows the translucent tab effect to work (otherwise content would be clipped and there would be no translucency). However, this had the unintended side effect of causing page transitions to flow outside of these components. This is most noticeable on larger displays when using SplitPane because the page can cover the menu mid-transition.
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build
7.6.3-dev.11703103144.148eb1f6
Before/After Demo
main
before-transition.mov
after-transition.mov
Screenshot Diffs
The
menu-custom
screenshot diffs (Example) are correct. By addingoverflow: hidden
, the box shadow from the "Content" header no longer flows outside of the container.The menu border on MD has an opacity of 0.18, so the border color was mixing with the color of the box shadow from the header.
Since the shadow no longer flows outside of the container, the border color does not mix with the box shadow color.
Does this break translucent tabs when the split pane is inside of a tab?
No. The split pane has
contain: strict
set which prevents content from flowing under the tab bar, so the translucent tab bar never worked with this layout.