feat(checkbox): update styles to iOS 17 specs #28729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetaPC
commented
Dec 19, 2023
Comment on lines
+291
to
+294
| $alert-ios-checkbox-icon-top: calc($alert-ios-checkbox-size / 8) !default; | ||
|
|
||
| /// @prop - Start of the icon in the checkbox alert | ||
| $alert-ios-checkbox-icon-start: calc($alert-ios-checkbox-size / 3 + 1px) !default; | ||
| $alert-ios-checkbox-icon-start: calc($alert-ios-checkbox-size / 3) !default; |
There was a problem hiding this comment.
These changes were made to align the icon to the center.
thetaPC
commented
Dec 19, 2023
thetaPC
requested review from
brandyscarney,
averyjohnston and
a team
as code owners
|
Switching to draft to compare values with native. |
brandyscarney
approved these changes
Dec 20, 2023
| @@ -16,6 +16,9 @@ | |||
|
|
|||
| // Size | |||
| --size: #{$checkbox-ios-icon-size}; | |||
|
|
|||
| // Checkmark width | |||
| --checkmark-width: #{$checkbox-ios-icon-checkmark-width}; | |||
There was a problem hiding this comment.
| @@ -20,12 +20,10 @@ | |||
| * @prop --transition: Transition of the checkbox icon | |||
| * | |||
| * @prop --checkmark-color: Color of the checkbox checkmark when checked | |||
| * @prop --checkmark-width: Stroke width of the checkbox checkmark | |||
There was a problem hiding this comment.
Sorry I did not mean to remove the @prop here. This will remove it from the documentation. I just meant the value below.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
iOS checkbox does not align with the styles on iOS 17.
What is the new behavior?
iOS checkbox aligns with the styles on iOS 17.
Does this introduce a breaking change?
Other information
I noticed that the checkbox width was also different. Based on some comparisons,
1.5pxwas the most accurate.