Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action-sheet): adjust height for safe area with scrollable options #28504

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

brandyscarney
Copy link
Member

Issue number: fixes #27777


What is the current behavior?

When safe area (top/bottom) is applied to an action sheet with scrollable options and a cancel button, the cancel button is pushed off the screen and cannot be reached.

What is the new behavior?

Properly adjust the height of the action sheet container to account for the top and bottom safe area.

Does this introduce a breaking change?

  • Yes
  • No

Other information

The below screenshots use the following CSS when safe area is added so it is expected that the action sheet will adjust the top and bottom:

:root {
  --ion-safe-area-top: 60px;
  --ion-safe-area-bottom: 40px;
}

iOS

Before (main) After (FW-4715)
No Safe Area ios-main-no-safe-area ios-branch-no-safe-area
Safe Area ios-main-safe-area ios-branch-safe-area

Material Design

Before (main) After (FW-4715)
No Safe Area md-main-no-safe-area md-branch-no-safe-area
Safe Area md-main-safe-area md-branch-safe-area

@github-actions github-actions bot added the package: core @ionic/core package label Nov 9, 2023
@brandyscarney brandyscarney marked this pull request as ready for review November 9, 2023 19:23
@brandyscarney brandyscarney requested review from liamdebeasi and a team November 9, 2023 19:23
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried dev build 7.5.5-dev.11699885110.10e38569 in the reproduction app provided in the original issue, and this fix works great!

@brandyscarney brandyscarney added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit 900267e Nov 13, 2023
55 checks passed
@brandyscarney brandyscarney deleted the FW-4715 branch November 13, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: long action sheet with safe area pushes cancel button off screen
4 participants