fix(alert): date inputs render correctly in mobile safari #28495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
commented
Nov 9, 2023
sean-perkins
requested review from
a team and
averyjohnston
and removed request for
a team
averyjohnston
suggested changes
Nov 13, 2023
...ponents/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-ios-ltr-Mobile-Safari-linux.png
Outdated
Show resolved
Hide resolved
averyjohnston
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28494
What is the current behavior?
The appearance of the input is being set to
nonewhich clears the browser appearance settings for height on the control. This results in the<input type="date" />to render without a height.What is the new behavior?
Does this introduce a breaking change?
Other information
We have screenshots for this component, but Playwright runs an emulation of Mobile Safari that does not reproduce this issue that is only present on device. There for we cannot write a test on this change.