feat(radio-group): add compareWith property #28452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sean Perkins <[email protected]>
github-actions
bot
added
package: angular
mapsandapps
requested review from
averyjohnston,
liamdebeasi,
thetaPC and
sean-perkins
as code owners
liamdebeasi
suggested changes
Nov 3, 2023
core/src/components/radio-group/test/compare-with/radio-group.e2e.ts
Outdated
Show resolved
Hide resolved
liamdebeasi
reviewed
Nov 3, 2023
| @@ -0,0 +1,37 @@ | |||
| type CompareFn = (currentValue: any, compareValue: any) => boolean; | |||
|
|
|||
| export const compareOptions = ( | |||
There was a problem hiding this comment.
Can we add a JSDoc for compareOptions too like we did for isOptionSelected?
liamdebeasi
changed the title
mapsandapps
changed the title
liamdebeasi
approved these changes
Nov 6, 2023
Co-authored-by: Liam DeBeasi <[email protected]>
|
@mapsandapps Don't forget to close #18943 too. GitHub doesn't autoclose linked issues when merging into the non-primary branch. |
|
@liamdebeasi thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #18943
What is the current behavior?
Radio Group only allows for a strict equality check between the value and the options.
What is the new behavior?
compareWithwhich can be a function or string.compareWithis a string, the Radio Group will compare the value of that key.compareWithis a function, the Radio Group will use that function to determine the selected option.Does this introduce a breaking change?
Other information
Docs PR is incoming.