Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): run platform subscriptions inside zone #28404

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix(angular): run platform subscriptions inside zone #28404

merged 2 commits into from
Oct 25, 2023

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Oct 24, 2023

Issue number: #19539


What is the current behavior?

When an app uses Capacitor, then the platform subscriptions will run outside of the Angular Zone.

What is the new behavior?

  • The platform subscriptions will run inside of the Angular Zone regardless if it uses Capacitor or not.

Added an extra zone.run within the event listener.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: npm install @ionic/[email protected]

@github-actions github-actions bot added the package: angular @ionic/angular package label Oct 24, 2023
@thetaPC thetaPC marked this pull request as ready for review October 24, 2023 23:02
@thetaPC thetaPC requested a review from sean-perkins as a code owner October 24, 2023 23:02
@thetaPC thetaPC requested a review from a team October 24, 2023 23:02
@thetaPC thetaPC added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit a4b303e Oct 25, 2023
55 checks passed
@thetaPC thetaPC deleted the FW-208 branch October 25, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants