fix(react): avoid multiple invocations of onDidDismiss and onWillPresent #28020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sean-perkins
force-pushed
the
sp/FW-4989
branch
from
31c9cc4 to
792c502
Compare
liamdebeasi
approved these changes
Aug 22, 2023
aeharding
added a commit
to aeharding/voyager
that referenced
this pull request
Oct 8, 2023
aeharding
added a commit
to aeharding/voyager
that referenced
this pull request
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Resolves #28010
What is the current behavior?
onDidDismissandonWillPresentwill fire twice when having a manual binding in your implementation for inline overlays.e.g.:
Will result in:
What is the new behavior?
onDidDismissandonWillPresentdo not execute the callback handler twice per invocationDoes this introduce a breaking change?
Other information
Dev-build:
7.3.1-dev.11692305436.16a4008f