fix(item-sliding): account for options added before watcher #27915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
averyjohnston
approved these changes
Aug 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27910
What is the current behavior?
There is an edge case in our
ion-item-slidingcode where options can be added after thequerySelectorAllhas been run inupdateOptionsbut beforewatchForOptionshas been called which causes us to miss the newly created options. These options can never be shown as a result.What is the new behavior?
watchForOptionsis called before the initialupdateOptionscall so that we can re-runupdateOptionsin the event that options are added while that first call is running.Does this introduce a breaking change?
Other information
Dev build:
7.2.2-dev.11690983626.19a2a8cb