fix: safari no longer adjusts text in landscape #27787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
requested review from
a team and
mapsandapps
and removed request for
a team
|
Shouldn't this be automatically applied by autoprefixer? |
|
The files in ionic-framework/core/package.json Line 78 in 35f0ec5 |
mapsandapps
approved these changes
Jul 12, 2023
|
Ah interesting. I feel like they should be but that's another problem ha. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27782
What is the current behavior?
Ionic uses text-size-adjust to prevent browsers from resizing text in landscape mode in order to match native app behavior. However, WebKit only supports
-webkit-text-size-adjust, so this fix never applied to iOS devices.https://caniuse.com/?search=text-size-adjust
What is the new behavior?
-webkit-text-size-adjustwhere we usetext-size-adjustDoes this introduce a breaking change?
Other information
Landscape
Portrait (Should be no changes)