Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): remove invalid z-index style #27559

Merged
merged 1 commit into from
May 30, 2023
Merged

fix(angular): remove invalid z-index style #27559

merged 1 commit into from
May 30, 2023

Conversation

sean-perkins
Copy link
Contributor

Issue number: N/A

What is the current behavior?

The Angular implementation of ion-tabs uses SASS styles in the inline usage for styles:

styles: [`
  :host {
    z-index: $z-index-page-container;
  }
`]

However Angular is expecting CSS mark-up by default. This results in an invalid value being assigned to the z-index.

image (10)

What is the new behavior?

  • Removes the invalid style from the tabs stylesheet
  • Removes unnecessary leading whitespace from the template

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented May 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: angular @ionic/angular package label May 25, 2023
@sean-perkins sean-perkins requested review from a team, brandyscarney and liamdebeasi and removed request for a team and brandyscarney May 25, 2023 20:31
liamdebeasi
liamdebeasi approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sean-perkins sean-perkins added this pull request to the merge queue May 30, 2023
Merged via the queue into main with commit 2ce00cf May 30, 2023
@sean-perkins sean-perkins deleted the sp/angular-tabs-styles branch May 30, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
package: angular @ionic/angular package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sean-perkins @liamdebeasi