fix(radio): radio with modern syntax is keyboard navigable #27530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
reviewed
May 30, 2023
liamdebeasi
approved these changes
May 30, 2023
core/src/components/radio/radio.tsx
Outdated
| @@ -135,7 +135,7 @@ export class Radio implements ComponentInterface { | |||
| ev.stopPropagation(); | |||
| ev.preventDefault(); | |||
|
|
|||
| this.el.focus(); | |||
| this.nativeInput.focus(); | |||
There was a problem hiding this comment.
It looks like this causes some issues with the legacy syntax just in Safari. Doing a Shift+Tab to get back to the previous radio group requires pressing Shift+Tab twice.
Suggested change
| this.nativeInput.focus(); | |
| const element = this.legacyFormController.hasLegacyControl() ? this.el : this.nativeInput; | |
| element.focus(); |
Let's keep focusing this.el only when in the legacy syntax.
thetaPC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27268
What is the current behavior?
When tabbing on a radio group (modern syntax), it focuses on the next radio option inside the radio group. It replicates the behavior of the up/down keys.
What is the new behavior?
A spike ticket has been created to further investigate web accessibility and browser compatibility.
Does this introduce a breaking change?
Other information
N/A