fix(many): form controls labels have increased margin #27447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
changed the title
liamdebeasi
commented
May 11, 2023
| } | ||
|
|
||
| ::slotted([slot="end"]) { | ||
| @include margin(0, 0, 0, var(--margin)); |
There was a problem hiding this comment.
I incorrectly assumed that the margins in the slots should be the same as the margin between the control and the label, so I reverted the --margin usage.
averyjohnston
approved these changes
May 12, 2023
There was a problem hiding this comment.
Full disclosure that I didn't look through all the screenshots; Github seems to have somehow gotten even worse at rendering large PRs like this 😅 In the future it may be useful to make the changes per component and run the screenshot job each time, so that the screenshot commits are broken up into smaller chunks.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #27129
What is the current behavior?
Material Design has 16px of margin between the form control and the label, but we have 8px: https://m2.material.io/components/selection-controls#usage
What is the new behavior?
Note: This should only apply to labels that are on the same line as the form control. In other words, they do not apply to stacked/floating labels.
Does this introduce a breaking change?
Other information