-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: v7 ion-list
+ ion-radio
with new label behavior has a smaller interactive zone than in v6
#27159
Comments
Thanks for the report. Here is a dev build with a proposed fix if you are interested in testing: |
Thanks, I can confirm it fixes the problem vertically, but their is still a bit of space on the sides that is not "clickable" 😅 This is less critical, but if the fix is easy, it would be appreciable 😌 |
Yes, that is a separate bug which I have reported here: #27169. This bug (at least when clicking the spacing to the left) reproduces in Ionic 6 as well. |
Nice, thank you |
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> <!-- Issues are required for both bug fixes and features. --> Issue URL: resolves #27159 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Radio elements take up the full height when used inside of an item. This aligns with what checkbox and toggle do: Checkbox: https://github.com/ionic-team/ionic-framework/blob/cb8f07c5530ffc222580a3e3bae8dc85f62c73e5/core/src/components/checkbox/checkbox.scss#L42 Toggle: https://github.com/ionic-team/ionic-framework/blob/cb8f07c5530ffc222580a3e3bae8dc85f62c73e5/core/src/components/toggle/toggle.scss#L43 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.0.2-dev.11681223603.14da7831`
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> <!-- Please describe the current behavior that you are modifying. --> <!-- Issues are required for both bug fixes and features. --> Issue URL: resolves #27159 <!-- Please describe the behavior or changes that are being added by this PR. --> - Radio elements take up the full height when used inside of an item. This aligns with what checkbox and toggle do: Checkbox: https://github.com/ionic-team/ionic-framework/blob/cb8f07c5530ffc222580a3e3bae8dc85f62c73e5/core/src/components/checkbox/checkbox.scss#L42 Toggle: https://github.com/ionic-team/ionic-framework/blob/cb8f07c5530ffc222580a3e3bae8dc85f62c73e5/core/src/components/toggle/toggle.scss#L43 - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.0.2-dev.11681223603.14da7831`
resolves #27159 --------- <!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> <!-- Please describe the current behavior that you are modifying. --> <!-- Issues are required for both bug fixes and features. --> Issue URL: resolves #27159 <!-- Please describe the behavior or changes that are being added by this PR. --> - Radio elements take up the full height when used inside of an item. This aligns with what checkbox and toggle do: Checkbox: https://github.com/ionic-team/ionic-framework/blob/cb8f07c5530ffc222580a3e3bae8dc85f62c73e5/core/src/components/checkbox/checkbox.scss#L42 Toggle: https://github.com/ionic-team/ionic-framework/blob/cb8f07c5530ffc222580a3e3bae8dc85f62c73e5/core/src/components/toggle/toggle.scss#L43 - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.0.2-dev.11681223603.14da7831`
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prerequisites
Ionic Framework Version
v7.0.1
Current Behavior
Inside an
<ion-list>
When using the newlabel
slot of the<ion-radio>
instead of an<ion-label>
+ an<ion-radio>
, the interactive (clickable) zone of the<ion-radio>
is smaller than with Ionic v6.When you hover & click an item of the list, you still get the "hover" + "ripple" effects, but the radio button does not get selected unless you click the correct part of it.
In v6:
In v7:
Expected Behavior
You should be able to click anywhere in the
<ion-item>
and it should select the radio button (like it did in Ionic v6).(Or the
<ion-radio>
should take the entire size of the<ion-item>
).Steps to Reproduce
<ion-list>
with<ion-item>
&<ion-radio>
inside of it<ion-item>
until you get the "hover" effect, but not the "pointer" cursor<ion-item>
<ion-radio>
does not get selectedHere is what I get In Ionic v7:
Record.2023-04-10.215456.mp4
Here is what I had in Ionic v6:
Record.2023-04-10.215728.mp4
(The videos are a bit laggy, so it's not that easy to undestand by just watching them 😅)
Code Reproduction URL
https://github.com/Julien-Marcou/ionic-issue-27085
You can also this the problem live in the Ionic Documentation for
<ion-radio>
:https://ionicframework.com/docs/api/radio#justification
(It's easier to see when selecting the
MD
mode instead of the defaultiOS
as you get ripple effects when you click an<ion-item>
so that you clearly see that you have clicked the<ion-item>
but the<ion-radio>
does not get selected)Ionic Info
Additional Information
No response
The text was updated successfully, but these errors were encountered: