Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio-group): radios participate in form submission #27018

Merged
merged 6 commits into from
Mar 24, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 24, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #27016

Radios do not participate in form submission. The contents of ion-radio are in the Shadow DOM, and there are no inputs inside of ion-radio-group.

What is the new behavior?

  • ion-radio-group renders an input in the Light DOM that contains the name of the radio group as well as the value.
    Note: This input is never disabled because ion-radio-group does not have a disabled property. Feature Request: feat: add disabled property to radio-group #19520

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Mar 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Mar 24, 2023
@liamdebeasi liamdebeasi changed the title Fw 3819 fix(radio-group): radios participate in form submission Mar 24, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review March 24, 2023 14:45
@liamdebeasi liamdebeasi requested a review from a team as a code owner March 24, 2023 14:45
@liamdebeasi liamdebeasi merged commit 3b99c31 into main Mar 24, 2023
@liamdebeasi liamdebeasi deleted the FW-3819 branch March 24, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: radio group does not participate in form submission
2 participants