Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): inherit white-space in select-text to allow wrapping #26973

Merged
merged 23 commits into from
Mar 24, 2023

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Mar 15, 2023

This is a recreation of #26914 in order to run our screenshots


Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Adding ion-text-wrap to the parent ion-select does not wrap the values

Issue URL: #19949

What is the new behavior?

The .select-text now inherits white-space which allows the ion-select to take on any value for white-space, making ion-text-wrap work as well.

Does this introduce a breaking change?

  • Yes
  • No

@brandyscarney brandyscarney requested a review from a team as a code owner March 15, 2023 19:17
@stackblitz
Copy link

stackblitz bot commented Mar 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@brandyscarney
Copy link
Member Author

@liamdebeasi Can you take a look at approving this PR? Same as the other one I just ran the screenshot action. All the screenshots are updated to include the wrapping example.

@brandyscarney
Copy link
Member Author

@liamdebeasi This is ready for another review! I updated to include a test just for the wrapping.

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good! Just a couple clean up items and this is good to merge. Great job!

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@brandyscarney brandyscarney merged commit 19c1e25 into main Mar 24, 2023
@brandyscarney brandyscarney deleted the FW-3749 branch March 24, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants