-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): inherit white-space in select-text to allow wrapping #26973
Conversation
Run & review this pull request in StackBlitz Codeflow. |
@liamdebeasi Can you take a look at approving this PR? Same as the other one I just ran the screenshot action. All the screenshots are updated to include the wrapping example. |
@liamdebeasi This is ready for another review! I updated to include a test just for the wrapping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes look good! Just a couple clean up items and this is good to merge. Great job!
.../test/basic/select.e2e.ts-snapshots/select-action-sheet-diff-ios-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
This is a recreation of #26914 in order to run our screenshots
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Adding
ion-text-wrap
to the parention-select
does not wrap the valuesIssue URL: #19949
What is the new behavior?
The
.select-text
now inheritswhite-space
which allows theion-select
to take on any value forwhite-space
, makingion-text-wrap
work as well.Does this introduce a breaking change?