fix(select): emit single ionChange event for popover option selection #26796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Not a huge fan of the PR title, open to ideas. |
liamdebeasi
reviewed
Feb 15, 2023
sean-perkins
commented
Feb 16, 2023
| For checkboxes that do not render the label immediately next to the checkbox, developers may continue to use "ion-label" but must manually associate the label with the checkbox by using "aria-labelledby".`, | ||
| For checkboxes that do not render the label immediately next to the checkbox, developers may continue to use "ion-label" but must manually associate the label with the checkbox by using "aria-labelledby". | ||
|
|
||
| Developers can use the "legacy" property to continue using the legacy form markup. This property will be removed in an upcoming major release of Ionic where this form control will use the modern form markup.`, |
There was a problem hiding this comment.
If we are good with the wording here, I can follow-up with another PR to apply across all form controls for v7.
liamdebeasi
suggested changes
Feb 16, 2023
core/src/components/select-popover/test/basic/select-popover.e2e.ts
Outdated
Show resolved
Hide resolved
liamdebeasi
reviewed
Feb 16, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ion-selectwithinterface="popover", selecting an option will result in a duplicate emission of theionChangeevent.The duplicate emission issue spawns from: #23474
The root problem was that we had both a click handler on the radio and a
@Listendecorator forionChange, both invoking the callback handler for the popover options. When a radio is selected, it would fire the click handler directly attached to the element and then theion-radio-groupwould fire anionChangeevent, additionally executing the callback handler (again).Issue URL: Resolves #26789 (this issue is resolved as a result, but the problem is existent with a basic implementation in v7 beta).
What is the new behavior?
<ion-select interface="popover">emits a singleionChangeevent when an option is selected from single selectionanytypes within theSelectPopoverclassselect)ion-select-popoverion-checkboxto include information for developers to use thelegacyprop if they require the legacy form templateDoes this introduce a breaking change?
Other information
Dev-build:
7.0.0-dev.11676402953.118c3b36