Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(many): legacy form control does not warn when using aria-labelledby #26699

Merged
merged 4 commits into from
Jan 30, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 30, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26698

The legacy warning message incorrectly assumes that the label for each form control will display immediately next to the control. However, developers may still need to use ion-label when the label is not immediately next to the control.

What is the new behavior?

  • Updated the form controller to opt a component into the modern syntax if aria-label or aria-labelledby is present on the host
  • Updated the deprecation message to make it clear that devs can still use ion-label in some situations but they must manually use aria-labelledby

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Jan 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@liamdebeasi liamdebeasi changed the title Fw 3223 fix(many): legacy form control does not warn when using aria-labelledby Jan 30, 2023
@github-actions github-actions bot added the package: core @ionic/core package label Jan 30, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review January 30, 2023 20:15
@liamdebeasi liamdebeasi requested a review from a team as a code owner January 30, 2023 20:15
@liamdebeasi liamdebeasi merged commit 63f8525 into feature-7.0 Jan 30, 2023
@liamdebeasi liamdebeasi deleted the FW-3223 branch January 30, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants