fix(datetime): max and min works with showDefaultButtons #26257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: #26146
max and min dates are not considered when using confirmation buttons.
When no date is set, we do not filter time values based on the max/min. Only once a date has been selected should we filter the selectable time values based on the max/min.
The following check was only looking to see if
value
was set:ionic-framework/core/src/components/datetime/datetime.tsx
Line 1725 in dd98677
This meant that if devs were using
showDefaultButtons
,value
would not be defined until the dev clicked "Confirm". As a result, the time values were never being filtered based on max/min.What is the new behavior?
Does this introduce a breaking change?
Other information